Skip to content

Conversation

@ngussed
Copy link
Owner

@ngussed ngussed commented Nov 5, 2019

No description provided.

harjaus and others added 30 commits October 29, 2019 16:51
Merge Cucumber Exercises into Master
This is the start of the lab on acceptance testing. So far it covers the
basics of puppeteer and basic profiling.
Removed Activity section from README, deprecated
Some students were getting confused about how to solve task 4.2.4

The instructions should now make it easier for them to solve the problem.
The number of lines per function was too short.
The linter didn't pick up on poor brace positioning.

Linter now fixed.
The step definition file contained a lot of helper code.

The page object is now instantiated using a custom object.
A several helper functions removed and code moved to steps.
manifest still had a lot of scripts that were no longer needed.

These have now been removed.
@ngussed ngussed merged commit a4b7917 into ngussed:master Nov 5, 2019
@ngussed
Copy link
Owner Author

ngussed commented Nov 7, 2019

yes this done

ngussed pushed a commit that referenced this pull request Nov 12, 2019
ngussed pushed a commit that referenced this pull request Nov 12, 2019
Merge pull request #1 from web/master
Sign in to join this conversation on GitHub.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants